chore(deps): remove @panva/hkdf in favor of Web Cryptography API #13199
+23
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
@thoaltmann is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
thoaltmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
The https://github.com/panva/hkdf repository has been archived with the following notice in the readme:
So this PR replaces the dependency to @panva/hkdf with the proposed alternative using the Cryptography API. We had issues with jest and next-auth regarding ESM-imports from this package (which was fixed by mocking the surrounding methods, but that issue will not happen to others with this change).
I didn't create an issue for this, as the change was quickly made, so if any discussion is needed, it can be done here, or feel free to close the PR if there are other factors I am not aware of that would make this change problematic.
🧢 Checklist
🎫 Affected issues
n.a.
📌 Resources